Support all vehicles file #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredshone
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @fredshone's advice here: https://github.com/arup-group/BitSim/pull/130#issuecomment-1287056487 I added support for all vehicles file which will allow its' use with bitsim (https://github.com/arup-group/BitSim/pull/130#issuecomment-1286919046)
Context: through the vehicles file we can set speeds for different mode vehicles, e.g. bike and walk (agents walking on the network also need a 'walk vehicle') (we still use the transit vehicles file or PT as usual)
The main complication with this was that we don't use the
all_vehicles.xmlfile right now and would like that to still be possible. For that I needed to add an optional tag to some methods, as you will see below.Got a couple of bitsim tests here:
all_vehicles.xmlfile, also knows as the good old timesall_vehicles.xmlfile and output vehicles in subsequent biterations