Deploy all the things from Hackathon 2018 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
anandaroop
commented
Nov 18, 2018
anandaroop
commented
- Artist search Add artist search criterion #167
- Keyword search Add keyword search #168
- Attribution class search Add attribution class search #169
- More info in artwork modal Add additional artwork metadata to modal #170
- External link to selected artworks in Helix Add Helix link for selected works #171
- Better external url hygiene Get external urls from ENV → Context API #172
Also some churn to comply with RuboCop.
Ensure test database gets migrated during setup
Add artist search criterion
Add keyword search
Add attribution class search
Add additional artwork metadata to modal
Add Helix link for selected works
Add test coverage
Enzyme was trailing behind React. This update is necessary for writing specs for components that use Context.
SitesContext is in packaged up into it's own component, per the strategy outlined here: https://frontarm.com/articles/react-context-performance/ May not be strictly necessary since this particular Context doesn't hold any mutable state.
Get external urls from ENV → Context API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.