Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bid icon colors #2165

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Conversation

jonallured
Copy link
Member

These colors were previously assumed but are now required. Here's what it looks like now:

Screen Shot 2019-03-14 at 4 16 39 PM

@jonallured jonallured requested a review from damassi March 14, 2019 21:18
@peril-staging peril-staging bot added the Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes label Mar 14, 2019
@artsyit
Copy link
Contributor

artsyit commented Mar 14, 2019

Deploy preview for artsy-reaction ready!

Built with commit ad97a3c

https://deploy-preview-2165--artsy-reaction.netlify.com

@sweir27
Copy link
Contributor

sweir27 commented Mar 15, 2019

This looks good! Not sure what's up with jest 🤔

These colors were previously assumed but are now required.
@jonallured jonallured force-pushed the fix-big-icon-colors branch from ad97a3c to 21e37a6 Compare March 15, 2019 15:27
@jonallured
Copy link
Member Author

Rebased on latest master and it looks like it's green, just waiting on netlify.

@jonallured
Copy link
Member Author

☝️This netlify thing is a known issue, so I'm going to merge this sucker, thanks!

@jonallured jonallured merged commit 2528c38 into artsy:master Mar 15, 2019
@artsyit
Copy link
Contributor

artsyit commented Mar 15, 2019

🚀 PR was released in v15.5.1 🚀

@jonallured jonallured deleted the fix-big-icon-colors branch March 19, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants