Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@dblandin => [SearchResults] Add basic contents for a tab #2148

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

mzikherman
Copy link
Collaborator

search

This fleshes out the basic contents for a tab (I went ahead and did two tabs, artwork and artist).

We don't have the nice fallback list item so these are just placeholders for now.

Up next:

  • add in pagination
  • create fallback list item and add

This will 'complete' the functionality for a given tab, the rest of the tabs should follow.

@peril-staging peril-staging bot added the Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes label Mar 12, 2019
Copy link
Member

@dblandin dblandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should've mentioned this in the last PR as well, but since we're adding functionality, should these PRs be minor version bumps?

@dblandin dblandin added Version: Minor Indicates that this PR should have a minor deploy, usually for new features and removed Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes labels Mar 12, 2019
@dblandin dblandin merged commit f67076f into artsy:master Mar 12, 2019
@artsyit
Copy link
Contributor

artsyit commented Mar 12, 2019

🚀 PR was released in v15.1.0 🚀

@mzikherman
Copy link
Collaborator Author

@dblandin oh yea good call!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Version: Minor Indicates that this PR should have a minor deploy, usually for new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants