Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass props.color to /video credits #2136

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Conversation

eessex
Copy link
Contributor

@eessex eessex commented Mar 11, 2019

Minor, passes props.color to the video credits text, which was rendering black on black without.

Before:
Screen Shot 2019-03-11 at 3 56 19 PM

After:
Screen Shot 2019-03-11 at 3 55 59 PM

Not sure how long this bug has been around, but noticed that we are currently running a display campaign to direct traffic to the breaking glass video series, so seemed a good time to get those pages looking good.

@peril-staging peril-staging bot added the Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes label Mar 11, 2019
@artsyit
Copy link
Contributor

artsyit commented Mar 11, 2019

Deploy preview for artsy-reaction ready!

Built with commit 64b1dc0

https://deploy-preview-2136--artsy-reaction.netlify.com

@xtina-starr xtina-starr merged commit 3d2755f into artsy:master Mar 12, 2019
@artsyit
Copy link
Contributor

artsyit commented Mar 12, 2019

🚀 PR was released in v15.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants