Skip to content

Commit 123e717

Browse files
authored
Merge pull request #2172 from xtina-starr/artist-collections-rail-test
set up artist collections rail test
2 parents b3e9a38 + 4b3205c commit 123e717

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

src/Apps/Artist/Routes/Overview/index.tsx

+4-12
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {
1818
} from "Components/v2"
1919

2020
export interface OverviewRouteProps {
21-
ARTIST_COLLECTIONS_RAIL?: string // TODO: remove after CollectionsRail a/b test
21+
showCollectionsRail?: boolean // TODO: remove after CollectionsRail a/b test
2222
artist: Overview_artist & {
2323
__fragments: object[]
2424
}
@@ -34,11 +34,7 @@ class OverviewRoute extends React.Component<OverviewRouteProps, State> {
3434
}
3535

3636
componentDidMount() {
37-
// TODO: remove after CollectionsRail a/b test
38-
const showCollectionsRail =
39-
this.props.ARTIST_COLLECTIONS_RAIL || sd.ARTIST_COLLECTIONS_RAIL
40-
41-
if (showCollectionsRail) {
37+
if (this.props.showCollectionsRail) {
4238
this.trackingCollectionsRailTest()
4339
}
4440
}
@@ -63,8 +59,7 @@ class OverviewRoute extends React.Component<OverviewRouteProps, State> {
6359
@track<OverviewRouteProps>(props => {
6460
// TODO: remove after CollectionsRail a/b test
6561
const experiment = "artist_collections_rail"
66-
const variation =
67-
props.ARTIST_COLLECTIONS_RAIL || sd.ARTIST_COLLECTIONS_RAIL
62+
const variation = sd.ARTIST_COLLECTIONS_RAIL
6863

6964
return {
7065
action_type: Schema.ActionType.ExperimentViewed,
@@ -80,10 +75,7 @@ class OverviewRoute extends React.Component<OverviewRouteProps, State> {
8075
}
8176

8277
render() {
83-
const { artist } = this.props
84-
const collectionsRailVariation =
85-
this.props.ARTIST_COLLECTIONS_RAIL || sd.ARTIST_COLLECTIONS_RAIL
86-
const showCollectionsRail = collectionsRailVariation === "experiment"
78+
const { artist, showCollectionsRail } = this.props
8779

8880
const showArtistInsights =
8981
showMarketInsights(this.props.artist) || artist.insights.length > 0

0 commit comments

Comments
 (0)