set up artist collections rail test #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peril-staging
bot
added
Jira Synced
Version: Patch
|
Deploy preview for artsy-reaction ready! Built with commit 4b3205c |
|
Looks good from here, the props change makes more sense for sure 👍 |
|
I'm not sure what's up with the jest test and why they haven't finished running. |
|
This is passing on circle ci https://circleci.com/gh/artsy/reaction/29430 Going to go ahead and merge. |
|
🚀 PR was released in v15.5.5 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address: GROW-1139
This uses
showCollectionsRailto determine when to show the rails on the artist page.