Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toolchain] Fix eslint speed problem #5662

Merged
merged 1 commit into from
May 28, 2020
Merged

[Toolchain] Fix eslint speed problem #5662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ module.exports = {
jsx: true,
},
ecmaVersion: 6,
project: "./tsconfig.json",
// This significantly slows down linting and is needed for type-aware lint
// checks which we don't have atm.
// project: "./tsconfig.json",
sourceType: "module",
},
settings: {
Expand Down
76 changes: 40 additions & 36 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,41 +43,6 @@
"unlink-all": "yalc remove --all && yarn --check-files",
"webpack": "node --max_old_space_size=2048 -r dotenv/config -r @babel/register node_modules/.bin/webpack --config ./webpack"
},
"husky": {
"hooks": {
"pre-commit": "lint-staged",
"pre-push": "yarn type-check"
}
},
"lint-staged": {
"*.@(js|jsx|ts|tsx)": [
"yarn lint --fix",
"yarn prettier-write"
]
},
"reporterEnabled": "mocha-junit-reporter, spec",
"mochaJunitReporterReporterOptions": {
"mochaFile": "reports/mocha/test-results.xml"
},
"nyc": {
"check-coverage": true,
"report-dir": "./.nyc_output/",
"reporter": [
"lcov",
"text-summary"
],
"extension": [
".coffee",
".js"
],
"lines": 0
},
"prettier": {
"bracketSpacing": true,
"semi": false,
"singleQuote": false,
"trailingComma": "es5"
},
"resolutions": {
"@types/react": "16.9.34",
"babel-core": "7.0.0-bridge.0",
Expand Down Expand Up @@ -358,7 +323,7 @@
"jsdom-global": "3.0.2",
"json-loader": "0.5.7",
"konami-js": "0.0.2",
"lint-staged": "10.0.8",
"lint-staged": "^10.2.6",
"mime": "2.4.0",
"mocha": "3.4.1",
"mocha-junit-reporter": "1.22.0",
Expand Down Expand Up @@ -401,5 +366,44 @@
},
"optionalDependencies": {
"fsevents": "*"
},
"husky": {
"hooks": {
"pre-commit": "lint-staged",
"pre-push": "yarn type-check"
}
},
"lint-staged": {
"*.{md}": [
"yarn prettier-write"
],
"*.{js,jsx,ts,tsx}": [
"yarn lint --fix",
"yarn prettier-write"
]
},
"reporterEnabled": "mocha-junit-reporter, spec",
"mochaJunitReporterReporterOptions": {
"mochaFile": "reports/mocha/test-results.xml"
},
"nyc": {
"check-coverage": true,
"report-dir": "./.nyc_output/",
"reporter": [
"lcov",
"text-summary"
],
"extension": [
".coffee",
".js"
],
"lines": 0
},
"prettier": {
"bracketSpacing": true,
"printWidth": 80,
"semi": false,
"singleQuote": false,
"trailingComma": "es5"
}
}
Loading