build(deps): bump react-native from 0.72.17 to 0.73.9 #10739

gkartalis · 2024-09-10T13:59:22Z

This PR resolves PHIRE-1181

Description

Bumps react-native version from 0.72.17 to 0.73.9

What changed:

Debugging improvements
Console Log history in Hermes
Updated debugging docs
Experimental New Debugger
Stable Symlink Support in Metro
Better Android 14 support
Java bump from 11 to 17
Gradle Bump from 7.4.x to 8.1.x

You can read more info on RN 73 official blogpost

Which Deps were bumped and why:

@braze/react-native-sdk: 5.2.0 ~> 8.4.0
@react-native-async-storage/async-storage: 1.19.3 ~> 1.19.8
@react-native-clipboard/clipboard: 1.7.0 ~> 1.14.1
react-native-code-push: 8.1.0 ~> 8.3.1
react-native-gesture-handler: 2.13.1 ~> 2.19.0
react-native-webview: 13.6.2 ~> 13.6.3

React Native 0.73 will depend on Android Gradle Plugin (AGP) 8.x. This will require all the libraries to specify a namespace in their build.gradle file. RN team added a compatibility layer for libraries that haven't specified a namespace, but please consider updating your libraries nonetheless.

Patches:

Enhanced react native patch with .mock('../Libraries/Image/Image', () => mockComponent('../Libraries/Image/Image')) due to this issue.

DevExperience Before / After:

Metro is way faster when bundling the app (around ~2x faster)

Android builds have an insane boost that is mostly due to java 17 and gradle updates:

On emulator with cleared cache / deleted app:

Before	After

on emulator with cached build:

Before	After

Steps To Upgrade on your machine after this gets merged:

# Delete node modules and caches:
rm -rf node_modules && rm -rf .cache && rm -rf "$TMPDIR/metro*" && rm -rf "$TMPDIR/haste-map-*"

# install all the dependencies needed
yarn install:all

# you will most likely have to run also the following to bump hermes-engine:
cd ios && bundle exec pod update hermes-engine --no-repo-update & cd ..

Afterwards in order to bump JAVA:

For asdf users:

asdf install

For non-asdf users:

brew install --cask zulu@17

# Get path to where cask was installed to double-click installer
brew info --cask zulu@17

Important

For all (asdf/ non asdf users). After you install the JDK, update your JAVA_HOME environment variable in your .zshrc file. Afterwards run source ~/.zshrc to make it effective and restart your terminal.
If you used above steps, JDK will likely be at /Library/Java/JavaVirtualMachines/zulu-17.jdk/Contents/Home.
You can try out in the terminal by typing $JAVA_HOME to make sure that it was updated properly.

PR Checklist

I have tested my changes on iOS and Android.
I hid my changes behind a feature flag, or they don't need one.
I have included screenshots or videos, or I have not changed the UI.
I have added tests, or my changes don't require any.
I added an app state migration, or my changes do not require one.
I have documented any follow-up work that this PR will require, or it does not require any.
I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

bumps react-native to 0.73.9 - gkartalis

Need help with something? Have a look at our docs, or get in touch with us.

ArtsyOpenSource · 2024-09-10T14:07:41Z

This PR contains the following changes:

Dev changes (bumps react-native to 0.73.9 - gkartalis)

Generated by 🚫 dangerJS against 3a01245

gkartalis · 2024-09-10T14:04:01Z

.tool-versions

@@ -1,3 +1,3 @@
 nodejs 20.9.0
 ruby 3.1.4
-java zulu-11.58.15
+java zulu-17.50.19


Java bump to 17

gkartalis · 2024-09-10T14:06:06Z

android/app/src/main/java/net/artsy/app/MainActivity.kt

@@ -0,0 +1,99 @@
+package net.artsy.app


we had to re-write this with Kotlin 🙈

gkartalis · 2024-09-10T14:06:12Z

android/app/src/main/java/net/artsy/app/MainApplication.kt

@@ -0,0 +1,86 @@
+package net.artsy.app
+


we had to re-write this with Kotlin 🙈

gkartalis · 2024-09-10T14:08:48Z

metro.config.js

+    extraNodeModules: {
+      images: path.resolve(__dirname, "./images"), // Add this line for Metro to resolve 'images folder'
+    },


Big GOTCHA, images/ path stopped being recognised after the rn bump and we had to let metro config know where they are

gkartalis · 2024-09-10T14:09:12Z

package.json

+    "@react-native-async-storage/async-storage": "1.19.8",
+    "@react-native-clipboard/clipboard": "1.14.1",


Had to bump these in order for them to be rn 73 compliant

gkartalis · 2024-09-10T14:09:18Z

package.json

    "react-native-blob-util": "0.19.9",
    "react-native-blurhash": "1.1.11",
    "react-native-bootsplash": "3.2.0",
-    "react-native-code-push": "8.1.0",
+    "react-native-code-push": "8.3.1",


Had to bump in order for them to be rn 73 compliant

gkartalis · 2024-09-10T14:09:34Z

package.json

@@ -190,7 +191,7 @@
    "react-native-url-polyfill": "2.0.0",
    "react-native-view-shot": "3.8.0",
    "react-native-vimeo-iframe": "1.2.1",
-    "react-native-webview": "13.6.2",
+    "react-native-webview": "13.6.3",


Had to bump in order for them to be rn 73 compliant

gkartalis · 2024-09-10T14:09:43Z

package.json

    "react-native-config": "https://github.com/artsy/react-native-config.git#v1.4.12-artsy",
    "react-native-context-menu-view": "git+https://github.com/artsy/react-native-context-menu-view.git#v1.10.10-artsy",
    "react-native-dev-menu-android": "1.0.10",
    "react-native-device-info": "10.3.0",
    "react-native-document-picker": "9.3.0",
    "react-native-fast-image": "8.6.3",
    "react-native-fbsdk-next": "13.0.0",
-    "react-native-gesture-handler": "2.13.1",
+    "react-native-flipper": "0.265.0",
+    "react-native-gesture-handler": "2.19.0",


Had to bump in order for them to be rn 73 compliant

brainbicycle

This looks great!
Two small ones:

the braze push handling in MainActivity is commented out, I think it is still necessary? 🤔
I think the react native patch may have gotten some generated code carried along

brainbicycle · 2024-09-12T16:53:03Z

HACKS.md

+#### Explanation/Context:
+
+We had to patch Braze in order to proceed with the react native upgrade to 0.73.9. The patch was needed to support kotlin jvm target 17 and
+in order to also make targetCompatibility and sourceCompatibility compatible with the JAVA 17 which is the standard for newer rn versions starting 0.73.


we should do some braze testing on Android in QA!

we will probably need to test out both android & iOS thoroughly, had to bump to 8.4.0 in the end - will remove the hack entry

brainbicycle · 2024-09-12T16:56:56Z

android/app/src/main/java/net/artsy/app/MainApplication.kt

+            }
+            val token = task.result
+            // Log.i(TAG, "TOKEN firebase messaging token $token")
+            // Braze.getInstance(applicationContext).setRegisteredPushToken(token)


this meant to still be commented out? do we need this to get push tokens registered for braze on Android?

I was getting an error here when trying to build ~ I think that in the end we will need to bump braze to be compliant 🫨 .

Seems like they moved this function to JS side ~ will trigger betas after I address that to test if it works

android/gradlew

ios/Artsy/App_Resources/Info.plist

ios/Podfile

patches/react-native+0.73.9.patch

src/app/Components/PopoverMessage/PopoverMessageProvider.tsx

scripts/ci/build-for-tests-ios

gkartalis · 2024-09-13T15:16:30Z

Bumped braze to 8.4.0 in the end ~ moved the registration of the token to the JS side since I was getting build errors from a depracated method from setRegisteredPushToken tried some others and no luck thus I moved the token to the JS side.

Let me know if you have any concerns ~ but I Was thinking to open a separate PR for braze 🤷‍♂️

gkartalis · 2024-09-13T16:23:31Z

FreshBetas:

android-8.51.0-1674645836
ios - 8.51.0 - 2024.9.13.15

gkartalis · 2024-09-13T16:49:16Z

Braze works! Received notifications in both android / ios betas above

MrSltun

Thank you for pushing through this!! 💪 ⚡ 📈

brainbicycle · 2024-09-16T14:19:17Z

src/app/utils/PushNotification.ts

@@ -235,6 +236,8 @@ export async function configure() {
    // (optional) Called when Token is generated (iOS and Android)
    onRegister: async (token) => {
      try {
+        registerPushToken(token.token)


…ter token to JS

artsy-peril · 2024-09-23T16:01:19Z

@react-native/typescript-config

Author: Unknown

Description: Default TypeScript configuration for React Native apps

Homepage: https://github.com/facebook/react-native/tree/HEAD/packages/typescript-config#readme


Created	over 1 year ago
Last Updated	about 13 hours ago
License	MIT
Maintainers	2
Releases	365
Keywords	typescript, tsconfig and react-native

@react-native/babel-preset

Author: Unknown

Description: Babel preset for React Native applications

Homepage: https://github.com/facebook/react-native#readme


Created	over 1 year ago
Last Updated	about 13 hours ago
License	MIT
Maintainers	2
Releases	388
Direct Dependencies	`@babel/core`, `react-refresh`, `@babel/template`, `@babel/plugin-syntax-flow`, `@babel/plugin-transform-for-of`, `@babel/plugin-transform-spread`, `@babel/plugin-transform-classes`, `@babel/plugin-transform-runtime`, `@babel/plugin-transform-literals`, `@babel/plugin-transform-react-jsx`, `babel-plugin-transform-flow-enums`, `@babel/plugin-transform-parameters`, `@babel/plugin-transform-typescript`, `@react-native/babel-plugin-codegen`, `@babel/plugin-syntax-dynamic-import`, `@babel/plugin-transform-regenerator`, `@babel/plugin-transform-sticky-regex`, `@babel/plugin-transform-block-scoping`, `@babel/plugin-transform-destructuring`, `@babel/plugin-transform-function-name`, `@babel/plugin-transform-unicode-regex`, `@babel/plugin-syntax-optional-chaining`, `@babel/plugin-transform-react-jsx-self`, `@babel/plugin-transform-arrow-functions`, `@babel/plugin-transform-private-methods`, `@babel/plugin-syntax-export-default-from`, `@babel/plugin-transform-class-properties`, `@babel/plugin-transform-flow-strip-types`, `@babel/plugin-transform-modules-commonjs`, `@babel/plugin-transform-react-jsx-source`, `@babel/plugin-transform-numeric-separator`, `@babel/plugin-transform-optional-chaining`, `@babel/plugin-proposal-export-default-from`, `@babel/plugin-transform-async-to-generator`, `@babel/plugin-transform-object-rest-spread`, `@babel/plugin-transform-react-display-name`, `@babel/plugin-transform-computed-properties`, `@babel/plugin-transform-shorthand-properties`, `@babel/plugin-transform-optional-catch-binding`, `@babel/plugin-syntax-nullish-coalescing-operator`, `@babel/plugin-transform-async-generator-functions`, `@babel/plugin-transform-private-property-in-object`, `@babel/plugin-transform-nullish-coalescing-operator`, `@babel/plugin-transform-logical-assignment-operators` and `@babel/plugin-transform-named-capturing-groups-regex`
Keywords	babel, preset and react-native

New dependencies added: @react-native/babel-preset and @react-native/typescript-config.

Generated by 🚫 dangerJS against 3a01245

gkartalis self-assigned this Sep 10, 2024

artsy-peril bot added the Jira Synced label Sep 10, 2024

gkartalis force-pushed the gkartalis/bump-rn-to-73.9 branch from 9615470 to 21b596e Compare September 10, 2024 14:03

gkartalis changed the title ~~build(deps): bump react-native from 0.72.17 to 0.73.9~~ build(deps): bump react-native from 0.72.17 to 0.73.9 #WIP #DONOTMERGE Sep 10, 2024

gkartalis commented Sep 10, 2024

View reviewed changes

gkartalis force-pushed the gkartalis/bump-rn-to-73.9 branch from 3e57c3b to 04199af Compare September 11, 2024 08:46

gkartalis added the post-react-conf-updates label Sep 11, 2024

brainbicycle requested changes Sep 12, 2024

View reviewed changes

brainbicycle reviewed Sep 12, 2024

View reviewed changes

scripts/ci/build-for-tests-ios Outdated Show resolved Hide resolved

gkartalis requested review from brainbicycle, MounirDhahri, araujobarret, MrSltun and dariakoko September 13, 2024 15:14

gkartalis requested a review from damassi September 13, 2024 15:16

MrSltun previously approved these changes Sep 16, 2024

View reviewed changes

brainbicycle reviewed Sep 16, 2024

View reviewed changes

brainbicycle previously approved these changes Sep 16, 2024

View reviewed changes

gkartalis dismissed stale reviews from brainbicycle and MrSltun via 759d3c6 September 16, 2024 14:31

gkartalis force-pushed the gkartalis/bump-rn-to-73.9 branch 2 times, most recently from 759d3c6 to c709193 Compare September 19, 2024 09:01

gkartalis added 4 commits September 19, 2024 17:28

build(deps-js+ios): bump react-native from 0.72.17 to 0.73.9

bf853be

build(deps): bump reanimated and webview to work with 73

50bcdc0

fix: 'images' alias after rn upgrade

fdd3ea6

fix: type issues

da30992

gkartalis added 23 commits September 19, 2024 17:28

build(deps/tests): bump jsdom to fix setimmediate issue

a61b4ec

chore(hack): patch rn jest setup:

812fe83

docs(HACKS): add explanation for rn jest patch

0ebfb0a

fix: reanimated useEvent

11dea73

chore: bump cache

b06b9b4

fix: some tests

1b96367

secretsbaseline

adfa1fe

delete stale test

e4288c7

fix: detect secrets

07bbbca

chore: update patches

471a5fb

bump ios cache

1ebeef5

chore: remove hermes from build script now that it is by defaylt

2b67940

testing ios solutions

4d753be

add prjct dir to shellscript

d7e4c3a

patch revert

fb94bac

build(deps): bump braze sdk to be compatible with rn73 and move regis…

9f6a30a

…ter token to JS

chore: remove patch unused stuff

b1ff365

chore: stuff

19c1c3b

chore: stuff

029a3f9

bring back flipper

2bc60c5

Update yarn.lock file

f8f9721

chore: rebase

2efa3b2

bump reanimated

3a01245

gkartalis force-pushed the gkartalis/bump-rn-to-73.9 branch from 1090bec to 3a01245 Compare September 19, 2024 15:30

gkartalis added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Sep 19, 2024

artsy-peril bot merged commit 552c9dc into main Sep 19, 2024
7 checks passed

artsy-peril bot deleted the gkartalis/bump-rn-to-73.9 branch September 19, 2024 15:56

brainbicycle changed the title ~~build(deps): bump react-native from 0.72.17 to 0.73.9 #WIP #DONOTMERGE~~ build(deps): bump react-native from 0.72.17 to 0.73.9 Sep 23, 2024

MounirDhahri mentioned this pull request Nov 7, 2024

RFC: Trial Expo in Energy and/or Palette-Mobile, Spike on Eigen Risks, Rewards and Effort artsy/README#543

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(deps): bump react-native from 0.72.17 to 0.73.9 #10739

build(deps): bump react-native from 0.72.17 to 0.73.9 #10739

gkartalis commented Sep 10, 2024 •

edited

Loading

ArtsyOpenSource commented Sep 10, 2024 •

edited

Loading

gkartalis Sep 10, 2024

gkartalis Sep 10, 2024

gkartalis Sep 10, 2024

gkartalis Sep 10, 2024

gkartalis Sep 10, 2024

gkartalis Sep 10, 2024

gkartalis Sep 10, 2024

gkartalis Sep 10, 2024

brainbicycle left a comment

brainbicycle Sep 12, 2024

gkartalis Sep 13, 2024

gkartalis Sep 13, 2024

brainbicycle Sep 12, 2024

gkartalis Sep 13, 2024

gkartalis commented Sep 13, 2024

gkartalis commented Sep 13, 2024

gkartalis commented Sep 13, 2024

MrSltun left a comment

brainbicycle Sep 16, 2024

artsy-peril bot commented Sep 23, 2024

		"@react-native-async-storage/async-storage": "1.19.8",
		"@react-native-clipboard/clipboard": "1.14.1",

build(deps): bump react-native from 0.72.17 to 0.73.9 #10739

build(deps): bump react-native from 0.72.17 to 0.73.9 #10739

Conversation

gkartalis commented Sep 10, 2024 • edited Loading

Description

What changed:

Which Deps were bumped and why:

Patches:

DevExperience Before / After:

Steps To Upgrade on your machine after this gets merged:

PR Checklist

To the reviewers 👀

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

ArtsyOpenSource commented Sep 10, 2024 • edited Loading

This PR contains the following changes:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brainbicycle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gkartalis commented Sep 13, 2024

gkartalis commented Sep 13, 2024

gkartalis commented Sep 13, 2024

MrSltun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

artsy-peril bot commented Sep 23, 2024

gkartalis commented Sep 10, 2024 •

edited

Loading

ArtsyOpenSource commented Sep 10, 2024 •

edited

Loading