Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scheduled:standup-reminder task #24

Merged
merged 8 commits into from
Feb 8, 2021

Conversation

dblandin
Copy link
Member

@dblandin dblandin commented Feb 6, 2021

This is the first of a few tasks that I plan to migrate over to the CLI to simplify some of our culture ops automation.

The idea is to invoke this task on a similar schedule (every Monday morning at 9am ET) via GitHub Actions (probably in the artsy/README repo).

https://github.com/artsy/peril-settings/blob/master/tasks/standupReminder.ts

#FF #FutureFriday

Example

The output here is intended for a Slack destination. The output includes formatted Slack @-mentions and links.

$ artsy scheduled:standup-reminder
<@U2JA8FG15>, <@U0QRCNUAV> based on our on-call schedule, you’ll be running the Monday standup at 12:00 noon NYC time. Here are the docs <https://github.com/artsy/README/blob/master/events/open-standup.md|on GitHub>. Add new standup notes <https://www.notion.so/artsy/Standup-Notes-28a5dfe4864645788de1ef936f39687c|in Notion>.

Screen Shot 2021-02-06 at 1 35 51 AM

@dblandin dblandin added ff Future Fursday/Friday Version: Minor labels Feb 6, 2021
@dblandin dblandin force-pushed the dblandin/scheduled-standup-reminder branch 3 times, most recently from 40fced1 to d4b9856 Compare February 6, 2021 06:32
@dblandin
Copy link
Member Author

dblandin commented Feb 6, 2021

I'm thinking about reorganizing this and the corresponding artsy/README PR: artsy/README#367

  • For any command that is expected to format output for Slack, support a --format string argument, defaulting to plain.
  • If --format=plain, output a plain text representation of the output
  • If --format=slack, output a JSON object adhering to the Slack message payload spec

That should give us the ability to format richer input here and rely less on downstream clients to reformat output for Slack. Thoughts?

@dblandin dblandin force-pushed the dblandin/scheduled-standup-reminder branch 5 times, most recently from 386d615 to d01df00 Compare February 7, 2021 21:33
dblandin added a commit to artsy/peril-settings that referenced this pull request Feb 8, 2021
Experimenting with a GitHub Action + Artsy CLI approach.

- artsy/README#367
- artsy/cli#24
dblandin added a commit to artsy/peril-settings that referenced this pull request Feb 8, 2021
Experimenting with a GitHub Action + Artsy CLI approach.

- artsy/README#367
- artsy/cli#24
Copy link
Member

@jonallured jonallured left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this direction and thinking, very cool stuff @dblandin!! 🙌 ❤️ 🏆

- Extract OpsGenie code into utility class
- Fix custom TypeScript types with `ts-node/register/transpile-only` mocha option
**Example**

```
$ artsy on-call:who
Devon Blandin
Jon Allured
```
@dblandin dblandin force-pushed the dblandin/scheduled-standup-reminder branch from bcc34a0 to c388334 Compare February 8, 2021 16:16
This is the first of a few tasks that I plan to migrate over to the CLI to
simplify some of our culture ops automation.

The idea is to invoke this task on a similar schedule (every Monday morning at
9am ET) via GitHub Actions (probably in the artsy/README repo).

https://github.com/artsy/peril-settings/blob/master/tasks/standupReminder.ts
Outputs a Slack-formatted message including open RFC issues in the Artsy GitHub org.

**Example**

```
$ artsy scheduled:rfcs
{"text":"There is one open RFC:","attachments":[{"fallback":"Open RFCs","color":"#36a64f","author_name":"jonallured","author_link":"https://github.com/jonallured","title":"RFC: Slight Rebranding for Artsy Engineering","title_link":"https://github.com/artsy/README/issues/364"}],"unfurl_links":false}
```
@dblandin dblandin force-pushed the dblandin/scheduled-standup-reminder branch from c388334 to bc4dd5d Compare February 8, 2021 16:31
@dblandin dblandin merged commit adadd68 into master Feb 8, 2021
@artsyit
Copy link
Contributor

artsyit commented Feb 8, 2021

🚀 PR was released in v0.4.0 🚀

@artsyit
Copy link
Contributor

artsyit commented Feb 8, 2021

🚀 PR was released in v0.4.0 🚀

@artsyit
Copy link
Contributor

artsyit commented Feb 8, 2021

🚀 PR was released in v0.4.0 🚀

5 similar comments
@artsyit
Copy link
Contributor

artsyit commented Feb 8, 2021

🚀 PR was released in v0.4.0 🚀

@artsyit
Copy link
Contributor

artsyit commented Feb 8, 2021

🚀 PR was released in v0.4.0 🚀

@artsyit
Copy link
Contributor

artsyit commented Feb 8, 2021

🚀 PR was released in v0.4.0 🚀

@artsyit
Copy link
Contributor

artsyit commented Feb 8, 2021

🚀 PR was released in v0.4.0 🚀

@artsyit
Copy link
Contributor

artsyit commented Feb 8, 2021

🚀 PR was released in v0.4.0 🚀

@dblandin dblandin deleted the dblandin/scheduled-standup-reminder branch February 12, 2021 23:12
dblandin added a commit to artsy/README that referenced this pull request Feb 15, 2021
This workflow was pinned to the alpha NPM tag while
artsy/cli#24 was still open.

We can use the stable channel now.
dblandin added a commit to artsy/README that referenced this pull request Feb 15, 2021
This workflow was pinned to the alpha NPM tag while
artsy/cli#24 was still open.

We can use the stable channel now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ff Future Fursday/Friday released Version: Minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants