Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine signals #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Combine signals #78

wants to merge 2 commits into from

Conversation

AndrewSB
Copy link
Contributor

I thought this was useful, but it does make the library larger. Thoughts?

AndrewSB added 2 commits April 24, 2019 10:53
@AndrewSB
Introduce MergeSignals.swift with merge & combineLatest
34d6450
@AndrewSB
Add option with 3 signals to merge & combineLatest
52a920d 
Maybe it would have been nice to use .tt or .gyb, but it would have
taken longer. So just manual for now.

Also, it might be useful to have a 4 & 5 variant.
@AndrewSB
Copy link
Contributor Author

Flaky travis:

SignalsTests iOS:
xctest (13908) encountered an error (Failed to load the test bundle. (Underlying error: The bundle “SignalsTests iOS” couldn’t be loaded because it is damaged or missing necessary resources. The bundle is damaged or missing necessary resources. dlopen_preflight(/Users/travis/Library/Developer/Xcode/DerivedData/Signals-hbucudalqtyounamwskaiplydfgr/Build/Products/Release-iphonesimulator/SignalsTests iOS.xctest/SignalsTests iOS): Library not loaded: /usr/lib/libauto.dylib
Referenced from: /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
Reason: no suitable image found. Did find:
/usr/lib/libauto.dylib: mach-o, but not built for iOS simulator))
Test session results and logs:
/Users/travis/Library/Developer/Xcode/DerivedData/Signals-hbucudalqtyounamwskaiplydfgr/Logs/Test/Test-Signals iOS-2019.04.24_18-15-15-+0000.xcresult

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AndrewSB