Skip to content

Commit

Permalink
ci(build): build Docker images on pull requests without pushing
Browse files Browse the repository at this point in the history
Because we've been having issues with these builds across platforms, start building images (but not
pushing) on PRs to make sure things don't break before merging in
  • Loading branch information
mloberg committed Oct 17, 2022
1 parent 2b5823c commit 96db8cc
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 38 deletions.
1 change: 0 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ If you're adding a new image, make sure you have done the following.

* [ ] Added to lint workflow matrix (`.github/workflows/lint.yml`)
* [ ] Added to build workflow matrix (`.github/workflows/build.yml`)
* [ ] Added to build workflow matrix (`.github/workflows/build-pr.yml`)
* [ ] Added to Makefile (`Makefile`)
36 changes: 0 additions & 36 deletions .github/workflows/build-pr.yml

This file was deleted.

3 changes: 2 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- main
schedule: # Run everyday
- cron: "0 0 * * *"
pull_request:

jobs:
build:
Expand All @@ -30,7 +31,7 @@ jobs:
- uses: docker/build-push-action@v3
with:
context: ${{ matrix.elixir }}
push: true
push: ${{ github.event_name != 'pull_request' }}
tags: articulate/articulate-elixir:${{ matrix.elixir }}
platforms: linux/amd64,linux/arm64/v8
cache-from: type=registry,ref=articulate/articulate-elixir:${{ matrix.elixir }}
Expand Down

0 comments on commit 96db8cc

Please sign in to comment.