Fix cargo-about Artichoke license checksum errors on Windows #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, GitHub Actions's native checkout action `@actions/checkout` does Windows CRLF normalization. This breaks the SHA256 checksum of the license files used in `clarify` sections in cargo-about config files embedded in this repository, leading to warnings like this in CI: ``` 2022-10-01 17:18:11.8629067 +00:00:00 [WARN] failed to validate all files specified in clarification for crate artichoke 0.1.0-pre.0: checksum mismatch, expected a7f7d7c7ab9585b1c5e43d592c648d6d3fff7debcf7cfbde301f63b02157444d 2022-10-01 17:18:11.8632725 +00:00:00 [WARN] failed to validate all files specified in clarification for crate artichoke-backend 0.19.0: checksum mismatch, expected a7f7d7c7ab9585b1c5e43d592c648d6d3fff7debcf7cfbde301f63b02157444d ``` This commit adds an additional step to the composite action to ensure git is configured with LF EOL behavior and does not normalize using autocrlf See: - actions/checkout#135
Remove 'nightly'.
lopopolo
added
A-target
|
No warnings on windows in CI. Looks good to merge. |
lopopolo
added a commit
to artichoke/nightly
that referenced
this pull request
Oct 16, 2022
Pull in the fix for clarify checksum mismatch on windows: - artichoke/generate_third_party#36
lopopolo
added a commit
to artichoke/docker-artichoke-nightly
that referenced
this pull request
Oct 16, 2022
Pull in the fix for clarify checksum mismatch on windows: - artichoke/generate_third_party#36 Keep parity with nightly builder: - artichoke/nightly#107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, GitHub Actions's native checkout action
@actions/checkoutdoes Windows CRLF normalization. This breaks the SHA256 checksum of the license files used inclarifysections in cargo-about config files embedded in this repository, leading to warnings like this in CI:This commit adds an additional step to the composite action to ensure git is configured with LF EOL behavior and does not normalize using autocrlf
See: