Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some global upgrades #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some global upgrades #81

wants to merge 2 commits into from

Conversation

baltazorr
Copy link

  1. Now it works for several tags by single selector without additional code.
  2. Added bottom and top label positions.

@arthurgouveia
Copy link
Owner

As of now, I don't a ton of time to check everything, but I did see a few things that need a fix:

1 - No need for demo page. Use the gh-pages branch to update the live example;
2 - Don't replace the fakeCheckable for a div. An anchor is required due to accessibility.


el.css('display', 'none');
el.hide();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use jQuery here? Leave it as vanillaJS.

@baltazorr
Copy link
Author

Ok, I got it.
This changes was made for my need.
In my case I have a problems with fakeCheckable a tag. If I put fakeCheckbox tag in config and leave default as a, and make another changes by your comments did you approve my pull request?

@arthurgouveia
Copy link
Owner

I'll need further reading to be sure.
On Jul 1, 2014 12:25 PM, "Bogdan Symchych" [email protected] wrote:

Ok, I got it.
This changes was made for my need.
In my case I have a problems with fakeCheckable a tag. If I put
fakeCheckbox tag in config and leave default as a, and make another changes
by your comments did you approve my pull request?


Reply to this email directly or view it on GitHub
#81 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants