-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.15.0 regression - Support negative numbers in the timestamp regular expression #663
Conversation
If this is a-ok could you cut a release for this? |
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 1536 1536
Branches 244 244
=====================================
Hits 1536 1536
Continue to review full report at Codecov.
|
Thanks @JBKahn, we'll look this over then merge if it's all good. We're probably going to wait a little before releasing 0.15.1 in case any more obvious bugs arise. Is this one really messing you guys up? |
Yeah, especially since a lot of apps don't lock down the version and we have lots of historical dates being passed into arrow. |
Alright we'll speed things along then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, already had some issues with some places automatically picking up 0.15.0 if they din't lock the version and it was a sub-dependancy. |
This solves #662
Currently arrow does not allow you to pass in negative numbers for seconds relative to epoch when using strings. This patch is an attempt to fix this.