Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix 0.7.X crashing on Android #955

Merged
merged 2 commits into from
Jul 28, 2018
Merged

Conversation

pakoito
Copy link
Member

@pakoito pakoito commented Jul 28, 2018

This is another attempt at palliating #807, which is blocking releases

@pakoito pakoito requested a review from nomisRev July 28, 2018 17:27
@codecov
Copy link

codecov bot commented Jul 28, 2018

Codecov Report

Merging #955 into master will increase coverage by 0.04%.
The diff coverage is 70%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #955      +/-   ##
============================================
+ Coverage     46.57%   46.61%   +0.04%     
  Complexity      643      643              
============================================
  Files           306      306              
  Lines          7964     7963       -1     
  Branches        816      816              
============================================
+ Hits           3709     3712       +3     
+ Misses         3928     3925       -3     
+ Partials        327      326       -1
Impacted Files Coverage Δ Complexity Δ
...ces-core/src/main/kotlin/arrow/instances/either.kt 67.44% <100%> (-0.74%) 0 <0> (ø)
...es-data/src/main/kotlin/arrow/instances/optiont.kt 68% <100%> (+1.33%) 0 <0> (ø) ⬇️
...es-data/src/main/kotlin/arrow/instances/eithert.kt 61.81% <100%> (+0.7%) 0 <0> (ø) ⬇️
...arrow-data/src/main/kotlin/arrow/data/SequenceK.kt 77.77% <100%> (-0.61%) 8 <1> (ø)
...sses/src/main/kotlin/arrow/typeclasses/Traverse.kt 66.66% <50%> (ø) 0 <0> (ø) ⬇️
...e/arrow-data/src/main/kotlin/arrow/data/WriterT.kt 47.05% <51.85%> (+1.05%) 7 <1> (ø) ⬇️
...sses/src/main/kotlin/arrow/typeclasses/Foldable.kt 52.5% <60%> (+0.11%) 0 <0> (ø) ⬇️
...e/arrow-data/src/main/kotlin/arrow/data/EitherT.kt 54.34% <75%> (+1.01%) 7 <0> (ø) ⬇️
...re/arrow-data/src/main/kotlin/arrow/data/StateT.kt 62.85% <81.25%> (+2.29%) 8 <0> (ø) ⬇️
...e/arrow-data/src/main/kotlin/arrow/data/OptionT.kt 59.61% <88.88%> (ø) 10 <0> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa07234...3e06d3c. Read the comment docs.

@pakoito pakoito merged commit 51d2078 into master Jul 28, 2018
@pakoito pakoito deleted the paco-fixnewandroidagain branch July 28, 2018 17:42
@pakoito
Copy link
Member Author

pakoito commented Jul 28, 2018

Merged as admin to test the Android problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant