Remove kapt sources hax for non-Android projects #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Later I'll check Android Studio stable, beta and canary and see if it works. If not I'll create issues on Google's and our bugtracker for that. |
andrzejressel
changed the title
|
Yep, just rechecked it on PC that didn't have arrow source and dir detection works fine: |
|
Merge whenever you're happy then :D |
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
========================================
Coverage 45.4% 45.4%
Complexity 647 647
========================================
Files 309 309
Lines 7972 7972
Branches 859 859
========================================
Hits 3620 3620
Misses 4035 4035
Partials 317 317Continue to review full report at Codecov.
|
|
thanks @jereksel ! |
RawToast
pushed a commit
to RawToast/kategory
that referenced
this pull request
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only not needed anymore, but in fact it breaks build (test
kaptKotlinis not included - at least on Linux, on Windows it seems to be working fine, I don't get it :-( ).