-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Android + Java 8 interaction #926
Conversation
The easiest way to test it would be to deploy a snapshot, if you can. |
@JorgeCastilloPrz gimme a green and I'll merge then :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good to go!
I don't know how to find the snapshot or how to use it, but this will not fully fix the problem, cause what I posted was a tiny example of the set of related issues, so this will likely just fix one of the instances of the problem but the build will still fail. |
Also, maybe #807 should not be closed until a working fix is on a release cause it is relevant for people looking to see if the issue is reported / handled. |
If this doesn't fix everything, we should create simple android project with everything as dependency and build it during tests to make sure this won't happen again. |
I already created a demonstrating minimal Android project that I linked on the original issue (#807): https://github.com/jrgonzalezg/arrow-android-failing But I don't see 0.7.3-SNAPSHOT published anywhere to update that repo to it although I have updated it now to 0.7.2 and extracted arrow version to a constant to make it easier to change for tests. Also if you run the build as indicated on that repo's README you can see the many instances of the issue besides |
Found the way to depend on 0.7.3-SNAPSHOT and updated the repo again: https://github.com/jrgonzalezg/arrow-android-failing |
Closes #807
Could @JorgeCastilloPrz @jrgonzalezg or @jereksel please check whether this fixes it? Or do we need to merge and use a snapshot to check it.
I'd say this is a blocker for 0.7.3, and we're ready for release afterwards.