Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android + Java 8 interaction #926

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Fix Android + Java 8 interaction #926

merged 1 commit into from
Jul 4, 2018

Conversation

pakoito
Copy link
Member

@pakoito pakoito commented Jul 4, 2018

Closes #807

Could @JorgeCastilloPrz @jrgonzalezg or @jereksel please check whether this fixes it? Or do we need to merge and use a snapshot to check it.

I'd say this is a blocker for 0.7.3, and we're ready for release afterwards.

@JorgeCastilloPrz
Copy link
Member

The easiest way to test it would be to deploy a snapshot, if you can.

@pakoito
Copy link
Member Author

pakoito commented Jul 4, 2018

@JorgeCastilloPrz gimme a green and I'll merge then :D

Copy link
Member

@JorgeCastilloPrz JorgeCastilloPrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good to go!

@pakoito pakoito merged commit 6cdacfc into master Jul 4, 2018
@pakoito pakoito deleted the paco-android8fix branch July 4, 2018 23:34
@jrgonzalezg
Copy link
Member

I don't know how to find the snapshot or how to use it, but this will not fully fix the problem, cause what I posted was a tiny example of the set of related issues, so this will likely just fix one of the instances of the problem but the build will still fail.

@jrgonzalezg
Copy link
Member

Also, maybe #807 should not be closed until a working fix is on a release cause it is relevant for people looking to see if the issue is reported / handled.

@andrzejressel
Copy link
Contributor

If this doesn't fix everything, we should create simple android project with everything as dependency and build it during tests to make sure this won't happen again.

@jrgonzalezg
Copy link
Member

jrgonzalezg commented Jul 13, 2018

I already created a demonstrating minimal Android project that I linked on the original issue (#807): https://github.com/jrgonzalezg/arrow-android-failing But I don't see 0.7.3-SNAPSHOT published anywhere to update that repo to it although I have updated it now to 0.7.2 and extracted arrow version to a constant to make it easier to change for tests. Also if you run the build as indicated on that repo's README you can see the many instances of the issue besides ListK.

@jrgonzalezg
Copy link
Member

Found the way to depend on 0.7.3-SNAPSHOT and updated the repo again: https://github.com/jrgonzalezg/arrow-android-failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow 0.7.x causes builds to fail on Android projects
4 participants