Fix Renzu generating for Ant, Kobalt and Maven #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeCastilloPrz
approved these changes
Jun 17, 2018
| val filesInDir = currentDirectory.list() | ||
|
|
||
| //Am I being to smart? Basically we want to check if there is an element that is in both fileNames and filesInDir | ||
| return if ((fileNames - filesInDir).isNotEmpty()) { |
There was a problem hiding this comment.
insersect would be readable, and then you can remove the comment.
https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/intersect.html
pakoito
reviewed
Jun 17, 2018
|
|
||
| fun recurseFilesUpwards(fileName: String, currentDirectory: File): File = | ||
| if (currentDirectory.list().contains(fileName)) { | ||
| fun recurseFilesUpwards(fileNames: Set<String>, currentDirectory: File): File { |
There was a problem hiding this comment.
Tailrec? Looks like tailrec to me.
pakoito
reviewed
Jun 17, 2018
| @@ -90,10 +90,13 @@ class RenzuGenerator( | |||
| } | |||
|
|
|||
| fun generate() { | |||
|
|
|||
| val topLevelFiles = setOf("settings.gradle", "pom.xml", "build.xml", "Build.kt") | |||
There was a problem hiding this comment.
Could you please add build.gradle.kt too? It's the Gradle API for Kotlin.
There was a problem hiding this comment.
I'll add settings.gradle.kt - build.gradle.kt can be in submodule.
RawToast
pushed a commit
to RawToast/kategory
that referenced
this pull request
Jul 18, 2018
* Fix Renzu generating for Ant, Kobalt and Maven * PR comments * Fix build * Add settings.gradle.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #889