-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve optics processor #852
Conversation
Add OpticsProcessor check to verify unnamed companion object
Update DSLTest with new syntax
Generate file per annotated target in corresponding directory
a3f51d8
to
34ba752
Compare
@arrow-kt/maintainers After discussion with @JorgeCastilloPrz I updated this PR to generated code as follows:
i.e.
Result should be in a file If everyone agrees should we write this down somewhere in a Contributor wiki? (I thought we had one, did we remove it?) |
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
=========================================
Coverage ? 44.65%
Complexity ? 615
=========================================
Files ? 303
Lines ? 7771
Branches ? 837
=========================================
Hits ? 3470
Misses ? 4000
Partials ? 301
Continue to review full report at Codecov.
|
else -> prism.left() | ||
} | ||
}, | ||
reverseGet = { it } | ||
reverseGet = ::identity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* fix AP tests * Add OpticsProcessor check to verify unnamed companion object * Generate single file per annotated element * Re-enabled grained control for DSL generation * Small clean up Optics processors * Remove unused reflection usage * Update formatting generated code Lens & Iso * Fix tests * Update DSLTest with new syntax * Update Snippet so it belongs to an annotated target * Generate file per annotated target in corresponding directory * Test code generation in correct folder structure
Closes #848