Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renzu missing instances and simplifying the tree #822

Merged
merged 3 commits into from
Apr 28, 2018

Conversation

JorgeCastilloPrz
Copy link
Member

@JorgeCastilloPrz JorgeCastilloPrz commented Apr 28, 2018

  • We've detected some missing instances on the graph. It was due to how new rounds where generating new typeclass instances blocks with the same name than older ones and that redundancy in the name was causing nomnoml to ignore those. Here I'm providing a fix to group them properly under the same typeclass instances block even if it was generated on a previous processing round. I'm doing it by rewriting the file with properly updated content each round.

  • I'm also simplyfing the tree by not rendering redundant instances for inherited typeclasses. That means that OptionMonoidInstance would is now rendered as direct instance of Monoid but not as an instance of Semigroup even if it's still valid. But in purpose of making a tree easier to understand I think it's working much better. This is how it looks like with these changes:

captura de pantalla 2018-04-28 a las 10 12 30

  • I've also fixed the problem causing multiple redundant arrows being rendered.

@codecov
Copy link

codecov bot commented Apr 28, 2018

Codecov Report

Merging #822 into master will increase coverage by 0.05%.
The diff coverage is 85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #822      +/-   ##
============================================
+ Coverage     44.17%   44.23%   +0.05%     
- Complexity      617      625       +8     
============================================
  Files           290      290              
  Lines          7396     7420      +24     
  Branches        828      831       +3     
============================================
+ Hits           3267     3282      +15     
- Misses         3830     3838       +8     
- Partials        299      300       +1
Impacted Files Coverage Δ Complexity Δ
...cessor/src/main/java/arrow/renzu/RenzuGenerator.kt 75.24% <85%> (+1.22%) 26 <11> (+9) ⬆️
...rocessor/src/main/java/arrow/renzu/ModuleStyles.kt 0% <0%> (-60%) 0% <0%> (ø)
...src/main/java/arrow/instances/AnnotatedInstance.kt 60% <0%> (-20%) 3% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabd8b2...d35467c. Read the comment docs.

@JorgeCastilloPrz JorgeCastilloPrz merged commit d3efcd3 into master Apr 28, 2018
@JorgeCastilloPrz JorgeCastilloPrz deleted the renzu-missing-instances branch April 28, 2018 11:12
RawToast pushed a commit to RawToast/kategory that referenced this pull request Jul 18, 2018
* remove wrong styling code

* refactor to render all the instances grouped

* remove instance redundancy for inherited typeclasses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants