Renzu missing instances and simplifying the tree #822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've detected some missing instances on the graph. It was due to how new rounds where generating new typeclass instances blocks with the same name than older ones and that redundancy in the name was causing
nomnoml
to ignore those. Here I'm providing a fix to group them properly under the same typeclass instances block even if it was generated on a previous processing round. I'm doing it by rewriting the file with properly updated content each round.I'm also simplyfing the tree by not rendering redundant instances for inherited typeclasses. That means that
OptionMonoidInstance
would is now rendered as direct instance ofMonoid
but not as an instance ofSemigroup
even if it's still valid. But in purpose of making a tree easier to understand I think it's working much better. This is how it looks like with these changes: