-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "plus" methods for Tuples #818
Conversation
|
||
} | ||
|
||
File("tuple.kt").writeText(fileContent.toString()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too useful to make it throwaway code, we can modify it for other functions. It cannot be shipped with the library tho, can you please move it to...
...to where?
Can you create a folder in the root of the project called scripts and drop it there? Will it even work? How did you invoke it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those scripts can live in the annotation processor which is not a runtime dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, of course :D Thanks for jumping into this!
I think the generator can be moved to the annotation processor and what is generated either to Tuple in core or in a different syntax place that is not |
I don't think it should be in annotation processor - it doesn't process any annotation. I'll create a directory in root and write readme file how to use them - in future we could create gradle task for that. |
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
============================================
- Coverage 44.29% 44.17% -0.12%
Complexity 617 617
============================================
Files 289 290 +1
Lines 7376 7396 +20
Branches 828 828
============================================
Hits 3267 3267
- Misses 3810 3830 +20
Partials 299 299
Continue to review full report at Codecov.
|
fixes #815