Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "plus" methods for Tuples #818

Merged
merged 5 commits into from
Apr 26, 2018
Merged

Add "plus" methods for Tuples #818

merged 5 commits into from
Apr 26, 2018

Conversation

andrzejressel
Copy link
Contributor

@andrzejressel andrzejressel commented Apr 24, 2018

fixes #815

@andrzejressel andrzejressel changed the title Add "plus" method for Tuples Add "plus" methods for Tuples Apr 24, 2018

}

File("tuple.kt").writeText(fileContent.toString())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too useful to make it throwaway code, we can modify it for other functions. It cannot be shipped with the library tho, can you please move it to...

...to where?

Can you create a folder in the root of the project called scripts and drop it there? Will it even work? How did you invoke it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those scripts can live in the annotation processor which is not a runtime dependency

Copy link
Member

@pakoito pakoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, of course :D Thanks for jumping into this!

@raulraja
Copy link
Member

I think the generator can be moved to the annotation processor and what is generated either to Tuple in core or in a different syntax place that is not collections unless there is other tuple stuff there already.

@andrzejressel
Copy link
Contributor Author

I don't think it should be in annotation processor - it doesn't process any annotation. I'll create a directory in root and write readme file how to use them - in future we could create gradle task for that.

@codecov
Copy link

codecov bot commented Apr 26, 2018

Codecov Report

Merging #818 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #818      +/-   ##
============================================
- Coverage     44.29%   44.17%   -0.12%     
  Complexity      617      617              
============================================
  Files           289      290       +1     
  Lines          7376     7396      +20     
  Branches        828      828              
============================================
  Hits           3267     3267              
- Misses         3810     3830      +20     
  Partials        299      299
Impacted Files Coverage Δ Complexity Δ
.../src/main/kotlin/arrow/syntax/collections/tuple.kt 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40baca8...599b466. Read the comment docs.

@andrzejressel andrzejressel merged commit dabd8b2 into arrow-kt:master Apr 26, 2018
RawToast pushed a commit to RawToast/kategory that referenced this pull request Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v0.7.0] arrow.syntax.tuples.plus operator fun no more available in version 0.7.0
3 participants