Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kotest duplicate testnames warning #3023

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

abendt
Copy link
Contributor

@abendt abendt commented Apr 3, 2023

There are some kotest warnings about duplicated test names: WARN: Duplicated test name ... . To disable this message, set DuplicateTestNameMode to Silent.

This MR fixes them by adding a name param to the Laws classes.

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @abendt to look into these things 🙌

@nomisRev nomisRev merged commit 64eff14 into arrow-kt:main Apr 3, 2023
@abendt abendt deleted the fix_duplicate_testnames_warning branch April 3, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants