Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow Resilience #2885

Merged
merged 9 commits into from
Jan 19, 2023
Merged

Arrow Resilience #2885

merged 9 commits into from
Jan 19, 2023

Conversation

serras
Copy link
Member

@serras serras commented Jan 9, 2023

This supersedes #2876, by creating a copy of CircuitBreaker and Schedule into a new arrow-fx-resilience package, and adding the corresponding deprecation warnings to the arrow-fx-coroutines versions.

@serras serras self-assigned this Jan 9, 2023
@serras serras added the 1.1.5 label Jan 9, 2023
@serras serras requested review from nomisRev and a team January 9, 2023 08:25
This was referenced Jan 9, 2023
@nomisRev
Copy link
Member

@serras I would postpone this until 1.2.0

@serras serras added 1.2.0 Tickets belonging to 1.1.2 and removed 1.1.5 labels Jan 11, 2023
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this can be merged now. Small nit for the deprecation message. Do we need to update any other documentation anywhere for the website?

…fx/coroutines/DeprecationWarnings.kt

Co-authored-by: Simon Vergauwen <[email protected]>
@serras serras merged commit ad8ea21 into main Jan 19, 2023
@serras serras deleted the fx-resilience-backport-1 branch January 19, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2.0 Tickets belonging to 1.1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants