fix imports for ksp plugin #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
requested changes
Mar 4, 2022
Comment on lines
8
to
11
| val sourceClassName = el.qualifiedName?.asString() ?: el.simpleName | ||
| val sourceName = el.simpleName.asString().replaceFirstChar { it.lowercase(Locale.getDefault()) } | ||
| val simpleName = el.simpleName.asString() | ||
| val packageName = pckg.asString() |
There was a problem hiding this comment.
Can we keep these names the same? This is our own domain.
This introduces a lot of unnecessary changes in the PR.
...-libs/optics/arrow-optics-ksp-plugin/src/main/kotlin/arrow/optics/plugin/internals/lenses.kt
Show resolved
Hide resolved
| @@ -38,7 +38,6 @@ class LensTests { | |||
| fun `Lenses which mentions imported elements`() { | |||
| """ | |||
| |$imports | |||
| |import kotlin.time.Duration | |||
There was a problem hiding this comment.
These tests were not running if this bug was not caught. Is it possible to make them run?
If this import is removed, then it should be using FQN on line 47.
There was a problem hiding this comment.
Was removed since I added a variable in the dslModel with a Duration type so the import is automatically added in $import
There was a problem hiding this comment.
Let me change those to FQNames instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2618
Status:
In progres