Implement filter function for Optional #2588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenguyenthanh
force-pushed
the
optional-filter
branch
from
e1b2171 to
9e54a25
Compare
|
Note that in optics libraries in other languages, filtering is usually not part of Optional, but of Fold. See the Haskell version for example. The reason is that the |
|
@lenguyenthanh I've turned this PR into a new one introducing |
|
@serras cool, I'll take a look. Should we close this pr now? |
|
@lenguyenthanh yes, I'm going to close this PR now. Feel free to re-open if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same functionality
filerin Monocle Optional.filter