Resource computation block #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-walker
reviewed
Nov 4, 2021
| }.use { it } | ||
| } shouldBe "error".left() | ||
| // Should be ExitCase.Cancelled but still Failure due to ShortCircuit | ||
| // Cont<R, A> will fix this issue by properly shifting and cancelling |
i-walker
reviewed
Nov 4, 2021
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/Resource.kt
Outdated
Show resolved
Hide resolved
i-walker
reviewed
Nov 5, 2021
| @@ -496,36 +530,6 @@ public sealed class Resource<out A> { | |||
| public fun <A> defer(f: suspend () -> Resource<A>): Resource<A> = | |||
| Resource.Defer(f) | |||
| } | |||
|
|
|||
| private suspend fun continueLoop( | |||
raulraja
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Computation block DSL for
Resource.It also rewrites the internals of
Resourceslightly, it now uses Kotlin Coroutines to unroll Resource through bracketingsuspend.This way we can guarantee that for every
Resourcethat startedacquisitionwe will call the finalizer in order (FIFO).