Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce traverse and sequence for nullable types #2519

Merged
merged 3 commits into from
Sep 20, 2021
Merged

introduce traverse and sequence for nullable types #2519

merged 3 commits into from
Sep 20, 2021

Conversation

myuwono
Copy link
Collaborator

@myuwono myuwono commented Sep 19, 2021

fixes #2518

pakoito
pakoito approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@pakoito pakoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea and the implementation

@nomisRev
Copy link
Member

nomisRev commented Sep 20, 2021 •
edited
Loading

You need to run, and commit ./gradlew apiDump to fix the binary comparability check.

since 1.0.0 we’ll track and guarantee binary compatibility

EDIT: I added this fix @myuwono in the hope to get this in for the 1.0.0 release later ;)
Thanks for the awesome contributions again 🙏 👏 🥳

@nomisRev nomisRev changed the base branch from main to release/1.0.0 September 20, 2021 09:14
@nomisRev nomisRev merged commit 58cf9b6 into arrow-kt:release/1.0.0 Sep 20, 2021
franciscodr added a commit that referenced this pull request Sep 20, 2021
@nomisRev @raulraja
@franciscodr @myuwono
Release 1.0.0 (#2514)
fc0ae25 
* Remove Atomic FU

* Retrigger CI

* Make publish task run on release/1.0.0

* Update AtomicRef to continuations api files

* Remove usage atomicfu wrappers

* Remove exhessive empty lines

* mpp root module config

* publish with `publishToMavenRepository`

* publish with `publish`

* publish linux native targets

* Restore Arrow versions

* introduce traverse and sequence for nullable types (#2519)

Co-authored-by: Simon Vergauwen <[email protected]>

Co-authored-by: raulraja <[email protected]>
Co-authored-by: franciscodr <[email protected]>
Co-authored-by: Mitchell Yuwono <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@pakoito pakoito pakoito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

["Request"] add traverseNullable and sequenceNullable
3 participants
@myuwono @nomisRev @pakoito