Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish missing targets #2485

Merged
merged 7 commits into from
Sep 13, 2021
Merged

publish missing targets #2485

merged 7 commits into from
Sep 13, 2021

Conversation

i-walker
Copy link
Member

No description provided.

@nomisRev
Copy link
Member

Can we combine all files into a single file? That way it runs as a single Github action, meaning the jobs can short-circuit each other if they fail.

nomisRev
nomisRev approved these changes Sep 12, 2021
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should see SNAPSHOT appear for all binaries now.

.github/workflows/publish.yml Outdated Show resolved Hide resolved
nomisRev
nomisRev approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I think there is a couple of redundant configurations.

.github/workflows/publish.yml Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
franciscodr
franciscodr approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nomisRev!

@nomisRev nomisRev merged commit 9779d4e into main Sep 13, 2021
@nomisRev nomisRev deleted the is-windows-publication branch September 13, 2021 08:43
@franciscodr
Copy link
Collaborator

And thanks to @i-walker, who has created this pull request 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscodr franciscodr franciscodr approved these changes

@nomisRev nomisRev nomisRev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-walker @nomisRev @franciscodr