Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose CoroutineScope in Fx #2469

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Expose CoroutineScope in Fx #2469

merged 4 commits into from
Aug 19, 2021

Conversation

nomisRev
Copy link
Member

This an binary breaking change, and this is a "semi" API breaking change.

Semi-breaking in that it only breaks for method references since the Kotlin compiler doesn't automatically ignore the unused receiver scope. Only parSequence can be overloaded without causing type ambuigity.

suspend fun add(i: Int): Int = i + 1
listOf(1, 2, 3).parTraverse(::add) // expected CoroutineScope.() -> Int
  • We should fix binary break using visbility HIDDEN for 0.13.2 -> 0.13.3

@nomisRev nomisRev requested a review from a team August 16, 2021 18:35
raulraja
raulraja approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nomisRev! 🙏

@raulraja raulraja requested a review from a team August 17, 2021 15:33
@i-walker i-walker merged commit f1ed807 into main Aug 19, 2021
@i-walker i-walker deleted the sv-fx-coroutinescope branch August 19, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@i-walker i-walker i-walker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomisRev @raulraja @i-walker