Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate explicit API mode #2447

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Activate explicit API mode #2447

merged 3 commits into from
Jul 14, 2021

Conversation

nomisRev
Copy link
Member

This PR activates explicit API Mode.

It adds explicit public all declarations, and adds return type wherever currently implicitly inferred.

@franciscodr
Copy link
Collaborator

Task linked: CU-9rrcyy Activate the Library mode

@nomisRev nomisRev requested a review from a team July 13, 2021 18:42
pablisco
pablisco approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@pablisco pablisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 times yes! Must have been tedious to update all these 😅

@nomisRev
Copy link
Member Author

@pablisco Yes, it was extremely tedious xD

@nomisRev nomisRev requested a review from a team July 14, 2021 09:01
raulraja
raulraja approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nomisRev !

@nomisRev nomisRev changed the title Active explicit API mode Activate explicit API mode Jul 14, 2021
@nomisRev nomisRev merged commit 0afdd9a into main Jul 14, 2021
@nomisRev nomisRev deleted the cu-9rrcyy-library-mode branch July 14, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@pablisco pablisco pablisco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nomisRev @franciscodr @pablisco @raulraja