-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JS for Arrow Fx #2444
Merged
Merged
Support JS for Arrow Fx #2444
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b60a153
Update Arrow Fx Coroutines & Test
nomisRev 855e795
Add support JS for Arrow Fx Stm
nomisRev 8d8706a
Merge branch 'main' into sv-js-fx-coroutines
nomisRev cc499f8
Update karma config, and add symlinks for all diferent modules
nomisRev 4690a88
Merge branch 'sv-js-fx-coroutines' of github.com:arrow-kt/arrow into …
nomisRev b9f9380
Fix karma config
nomisRev ff6bdf3
Push symlinks
nomisRev 2fcb596
Fix symlinks again..
nomisRev 2c1384b
Clean
nomisRev a6b1d6e
ktlintformat
nomisRev 927e885
Disable concurrent example 1
nomisRev 68c83a6
Increase Karma timeout
nomisRev 5b0f6a4
Change karma parms
nomisRev dd8cbcf
Use configured custom chrome headless
nomisRev 260bab6
remove captureConsole
nomisRev 350d14e
Re-add pingTimeout
nomisRev f6efbfb
Re-add browser disconnect
nomisRev 2437337
Retrigger CI second time
nomisRev e37baa3
Retrigger CI 3rd time
nomisRev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../karma.config.d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../karma.config.d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../karma.config.d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../karma.config.d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../karma.config.d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../karma.config.d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
arrow-libs/fx/arrow-fx-coroutines/src/jsMain/kotlin/arrow/fx/coroutines/predef.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package arrow.fx.coroutines | ||
|
||
actual fun timeInMillis(): Long { | ||
val x: Number = js("new Date().getTime()") | ||
return x.toLong() | ||
} |
32 changes: 32 additions & 0 deletions
32
...-libs/fx/arrow-fx-coroutines/src/jvmTest/kotlin/arrow/fx/coroutines/ParTraverseJvmTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
package arrow.fx.coroutines | ||
|
||
import io.kotest.assertions.assertSoftly | ||
import io.kotest.matchers.string.shouldStartWith | ||
import io.kotest.property.Arb | ||
import io.kotest.property.arbitrary.int | ||
|
||
class ParTraverseJvmTest : ArrowFxSpec(spec = { | ||
"parTraverse runs on provided context " { // 100 is same default length as Arb.list | ||
checkAll(Arb.int(min = Int.MIN_VALUE, max = 100)) { i -> | ||
val res = single.use { ctx -> | ||
(0 until i).parTraverse(ctx) { Thread.currentThread().name } | ||
} | ||
assertSoftly { | ||
res.forEach { it shouldStartWith "single" } | ||
} | ||
} | ||
} | ||
|
||
"parTraverseN runs on provided thread" { | ||
checkAll(Arb.int(min = Int.MIN_VALUE, max = 100)) { i -> | ||
val res = single.use { ctx -> | ||
(0 until i).parTraverseN(ctx, 3) { | ||
Thread.currentThread().name | ||
} | ||
} | ||
assertSoftly { | ||
res.forEach { it shouldStartWith "single" } | ||
} | ||
} | ||
} | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../karma.config.d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we can report to karma or somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to make a ticket for this in Kotlin. It's failing on generated code.