Move code Arrow-Core #2403
Move code Arrow-Core #2403
Conversation
| @@ -233,7 +233,7 @@ sealed class Eval<out A> { | |||
| is FlatMap<A> -> object : FlatMap<B>() { | |||
| override fun <S> start(): Eval<S> = (this@Eval).start() | |||
|
|
|||
| @IgnoreJRERequirement | |||
| // @IgnoreJRERequirement | |||
There was a problem hiding this comment.
It seems this annotation is not needed anymore. AnimalSniffer seems to pass on this code.
There was a problem hiding this comment.
Oh, I'm going to review AnimalSniffer configuration because maybe it must be updated with the last change.
There was a problem hiding this comment.
Alright, if we need it back we can turn it into a expect/actual annotation where native and JS have no-op annotations.
| * ``` | ||
| * | ||
| */ | ||
| // https://youtrack.jetbrains.com/issue/KT-36036 |
There was a problem hiding this comment.
Link to issue on Kotlin tracker.
This extension cannot live in NonFatal.kt anymore since it conflicts with the NonFatalKt file generated by jvmMain which has the expect implementation for NonFatal.kt.
| } | ||
| assertSoftly { | ||
| res.orNull()?.forEach { | ||
| it shouldStartWith "single" |
There was a problem hiding this comment.
We need to use shouldStartWith instead because KotlinX Coroutines post fixes the thread name with "@coroutine$id" if the -ea flag is enabled. Which it is with testing.
There was a problem hiding this comment.
Awesome work @nomisRev !! I'm going to check some things locally.
Co-authored-by: Rachel M. Carmena <[email protected]>
This PR moves all common code from
jvmMaintocommonMain.