More Either tests #2398
Merged
More Either tests #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-ivanov
commented
May 10, 2021
| Gen.int(), | ||
| Gen.int(), | ||
| Gen.int() | ||
| ) { a: Int, b: Int, c: Int -> |
There was a problem hiding this comment.
Gen.list is also possible, but I thought that showing list of Right is more explicit.
raulraja
approved these changes
May 10, 2021
| @@ -323,3 +454,12 @@ private suspend fun <A> throwException( | |||
| a: A | |||
| ): Either<Throwable, Any> = | |||
| throw RuntimeException("An Exception is thrown while handling the result of the supplied function.") | |||
|
|
|||
| private fun forAllSmallInt(fn: PropertyContext.(a: Int) -> Boolean) = | |||
There was a problem hiding this comment.
I believe we have some other utilities like these somewhere. Perhaps these functions should be moved there and made public or internal.
|
Welcome to Arrow @a-ivanov !! 🎉 |
|
And thank you so much!! 🙌 |
|
Thanks everyone for the warm welcome! Hope not to disappoint in future and contribute more) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
My first PR. Improving Either test coverage.