Arrow Fx docs editorial review #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakoito
approved these changes
Feb 6, 2019
pakoito
reviewed
Feb 6, 2019
modules/docs/arrow-docs/docs/docs/effects/fx/polymorphism/README.md
Outdated
Show resolved
Hide resolved
# Conflicts: # modules/docs/arrow-docs/docs/docs/effects/fx/README.md # modules/docs/arrow-docs/docs/docs/effects/fx/async/README.md # modules/docs/arrow-docs/docs/docs/effects/fx/polymorphism/README.md
raulraja
approved these changes
Feb 10, 2019
There was a problem hiding this comment.
@MaureenElsberry This is awesome as usual and I'm very thankful and happy to have your help with these reviews 😘
|
I had fixed a bunch of links already on master, this diff has smashed over them 🙈 For example, is a regression. |
|
Let's get rid of those TOC at the top. They are a burden to maintain unless we automate it and then they would not be there in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small edits for the Arrow Fx, async, and polymorphism readmes