Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing instances monad transformers #1185

Merged
merged 7 commits into from
Dec 9, 2018
Merged

Missing instances monad transformers #1185

merged 7 commits into from
Dec 9, 2018

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Dec 9, 2018

Small change to some data types. I exposed value() on both the actual type and it's kinded version, and I made the value property private. This removed the need for fix() in a lot of cases.

1 law failing for Kleisli which I was unable to fix for now. So I made them internal for now. I'll make separate tickets for these if that's okay.

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed, thanks!

@nomisRev nomisRev merged commit 0235477 into master Dec 9, 2018
@nomisRev nomisRev deleted the simon-monadT branch December 9, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants