-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fiber #1103
Fiber #1103
Conversation
modules/effects/arrow-effects/src/main/kotlin/arrow/effects/typeclasses/Fiber.kt
Outdated
Show resolved
Hide resolved
modules/effects/arrow-effects/src/main/kotlin/arrow/effects/typeclasses/Fiber.kt
Outdated
Show resolved
Hide resolved
modules/effects/arrow-effects/src/main/kotlin/arrow/effects/typeclasses/Fiber.kt
Show resolved
Hide resolved
Good job dude :) you're fast! Shouldn't we add a couple of tests for both methods? |
modules/effects/arrow-effects/src/main/kotlin/arrow/effects/typeclasses/Fiber.kt
Show resolved
Hide resolved
@JorgeCastilloPrz there is not much to write tests for until |
True story, it's just an interface xD. Sry for the confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. We can wait til CancelToken
is in or merge and fix later. If there's no hurry I'd do the former, but totally your choice. Gj!
01e979a
to
da4df10
Compare
Codecov Report
@@ Coverage Diff @@
## master #1103 +/- ##
============================================
- Coverage 42.81% 42.78% -0.03%
Complexity 812 812
============================================
Files 397 398 +1
Lines 10915 10922 +7
Branches 1244 1244
============================================
Hits 4673 4673
- Misses 5882 5889 +7
Partials 360 360
Continue to review full report at Codecov.
|
#1043 is ready, let's rebase master and reuse the CancelToken added with Bracket on this one. Then ready to merge. |
e1a06c6
to
1785579
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, let's merge this!
I left the docs unpublished because this doesn't make a lot of sense without
Concurrent
.For that reason, I have also not published the code for
Deferred
and left it in docs. This should be enabled with theConcurrent
type class.Closes #1089