Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiber #1103

Merged
merged 5 commits into from
Nov 15, 2018
Merged

Fiber #1103

merged 5 commits into from
Nov 15, 2018

Conversation

nomisRev
Copy link
Member

I left the docs unpublished because this doesn't make a lot of sense without Concurrent.

For that reason, I have also not published the code for Deferred and left it in docs. This should be enabled with the Concurrent type class.

Closes #1089

@JorgeCastilloPrz
Copy link
Member

Good job dude :) you're fast! Shouldn't we add a couple of tests for both methods?

@nomisRev
Copy link
Member Author

@JorgeCastilloPrz there is not much to write tests for until Concurrent is ready? There is no logic implemented whatsoever.

@JorgeCastilloPrz
Copy link
Member

True story, it's just an interface xD. Sry for the confusion.

Copy link
Member

@JorgeCastilloPrz JorgeCastilloPrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. We can wait til CancelToken is in or merge and fix later. If there's no hurry I'd do the former, but totally your choice. Gj!

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #1103 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1103      +/-   ##
============================================
- Coverage     42.81%   42.78%   -0.03%     
  Complexity      812      812              
============================================
  Files           397      398       +1     
  Lines         10915    10922       +7     
  Branches       1244     1244              
============================================
  Hits           4673     4673              
- Misses         5882     5889       +7     
  Partials        360      360
Impacted Files Coverage Δ Complexity Δ
...src/main/kotlin/arrow/effects/typeclasses/Fiber.kt 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac6bd9...f3ce955. Read the comment docs.

@JorgeCastilloPrz
Copy link
Member

JorgeCastilloPrz commented Nov 14, 2018

#1043 is ready, let's rebase master and reuse the CancelToken added with Bracket on this one. Then ready to merge.

Copy link
Member

@JorgeCastilloPrz JorgeCastilloPrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's merge this!

@nomisRev nomisRev merged commit f4ad5be into master Nov 15, 2018
@nomisRev nomisRev deleted the simon-fiber branch November 15, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants