fix for surface rendering function

[9prady9]

Fixes #1603

[9prady9]

@shehzan10 Apparently, regular modDim backend function is also doing evaluate before it is modifying the meta data of Array.

The problem lies in dims being modified before data is evaluated. Since each JIT node is storing the original dims, when eval is called after moddims is done, the node is still using original dims to compute the array values.

@pavanky Does changing m_dims member variable in buffer JIT node whenever moddims is called have any side effects ?

[pavanky]

@shehzan10 didn't we fix this ?

[pavanky]

Ok, it looks like me and shehzan found the exact same bug for when inputs are NOT vectors and fixed that. We forgot to fix cases where input is a vector. It is a simple enough fix.

@9prady9 can you look at the following commit and send in a proper patch.
18a4e55

[9prady9]

@pavanky The fix is using function version of modDims instead of Array::modDims ?

[pavanky]

@9prady9 yes, the function version of modDims is updating the metadata properly. So it is easier to just call that than re-implement changing the metadata in surface.

[9prady9]

@shehzan10 This is ready for merge.

[pavanky]

@9prady9 can you look to see if any other functions in src/api/c/ are using arr.modDims and change those as well ? (except modDims function ofcourse :) )

[9prady9]

Sure

[9prady9]

There is only file histeq.cpp that used that and i changed that now.