Improvements to sort functions #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows complex sorting based on a key, which can be the abs, real, imag etc of the value array. So the user can choose which metric they want to use.
* Sort now allows all dimensions * Sort if much faster by using batched mode. This takes up more memory though. * Enabled large tests for sort * Added tests for sorting on dim1 and dim2
This reverts commit 98e023d.
shehzan10
changed the title
|
build arrayfire windows ci |
|
@pavanky updated sort_index code for CPU and CUDA |
|
build arrayfire tegrak1 ci |
|
build arrayfire tegrak1 ci |
shehzan10
changed the title
|
build arrayfire linux-03 ci |
| cuda::kernel::iota<uint>(pSeq, seqDims, tileDims); | ||
|
|
||
| // Make pkey, pVal into a pair | ||
| thrust::device_vector<IndexPair<Tk, Tv> > X(inDims.elements()); |
There was a problem hiding this comment.
Allocate using arrayfire. This is going to be costly otherwise.
|
@shehzan10 Tests look fine. |
|
looks good 👍 |
|
build arrayfire ci |
1 similar comment
|
build arrayfire ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds:
Fixes #291 #394