Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARQ-2237 Create a BOM for arquillian-jakarta #5

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

rhusar
Copy link
Contributor

@rhusar rhusar commented Jul 1, 2024

@rhusar
Copy link
Contributor Author

rhusar commented Jul 1, 2024

@Jamez please review.

Copy link

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I do a full review, is there a reason not use the the parent POM?

@rhusar
Copy link
Contributor Author

rhusar commented Jul 1, 2024

Before I do a full review, is there a reason not use the the parent POM?

I am not sure, but that's the way it is setup in arquillian-core's bom. I suppose that's intentional so that yet another pom isn't being brought in.

@jamezp
Copy link

jamezp commented Jul 1, 2024

Before I do a full review, is there a reason not use the the parent POM?

I am not sure, but that's the way it is setup in arquillian-core's bom. I suppose that's intentional so that yet another pom isn't being brought in.

Okay, no problem. It's not a huge deal, I was just curious :)

bom/pom.xml Outdated Show resolved Hide resolved
@rhusar
Copy link
Contributor Author

rhusar commented Jul 1, 2024

Before I do a full review, is there a reason not use the the parent POM?

I am not sure, but that's the way it is setup in arquillian-core's bom. I suppose that's intentional so that yet another pom isn't being brought in.

Okay, no problem. It's not a huge deal, I was just curious :)

I think the dependencyManagement section from the parent would leak into the bom, right? So no parents here.

@starksm64 starksm64 merged commit 6697f16 into arquillian:main Jul 1, 2024
@rhusar rhusar deleted the ARQ-2237 branch July 1, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants