Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): aws-sdk version to avoid slow S3 calls bug upstream #20

Merged
merged 3 commits into from
Jan 24, 2020

Conversation

german-muzquiz
Copy link
Contributor

@german-muzquiz german-muzquiz commented Dec 13, 2019

There's a known issue in aws-sdk where calls to get an auth token inside kubernetes pods running in EC2 instances take a long time to complete (more than 20 seconds): aws/aws-sdk-go#2972
This change upgrades aws-sdk to the latest known version that doesn't have this problem.

@coveralls
Copy link

coveralls commented Dec 13, 2019

Pull Request Test Coverage Report for Build 147

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.783%

Totals Coverage Status
Change from base Build 145: 0.0%
Covered Lines: 150
Relevant Lines: 359

💛 - Coveralls

@ncknt ncknt merged commit c52f9d2 into master Jan 24, 2020
@ncknt ncknt deleted the fix/slow-s3 branch January 24, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants