Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBa8MPxL: cleanup fix X11 settings #7759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MBa8MPxL: cleanup fix X11 settings #7759

wants to merge 1 commit into from
+35 −36

Conversation

schmiedelm
Copy link
Member

Description

post_family_tweaks_bsp_ is called during the build of armbian-bsp-cli-xxx-current.

Since the cli package is built separately on the build server, comparisons on build parameters such as DESKTOP_ENVIRONMENT or BUILD_DESKTOP do not work.

So the X11 config is simply adapted for everyone.

How Has This Been Tested?

  • Build and Boot xfce image on mba8mp-ras314 and check X11 conf

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@schmiedelm
MBa8MPxL: cleanup fix X11 settings
382121d 
- post_family_tweaks_bsp_ is called during the build of armbian-bsp-cli-xxx
- the cli package is built separately on the build server
- comparisons to build parameters such as DESKTOP_ENVIRONMENT do not work

Signed-off-by: Martin Schmiedel <[email protected]>
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Jan 28, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release and removed Needs review Seeking for review labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmiedelm @igorpecovnik