Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pruning cron jobs should forbid concurrency #344

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Sovietaced
Copy link
Contributor

@Sovietaced Sovietaced commented Dec 10, 2024

Pull Request Template

Description

If pruning cron jobs have misconfigured timeouts/schedules they have an opportunity to run concurrently. We should forbid that.

Type of change

Please select the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code Style Update (formatting, renaming)
  • Refactor (code changes that do not fix a bug or add a feature)
  • Documentation Update
  • Other (please describe):

How Has This Been Tested?

Unit tests

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@Sovietaced Sovietaced changed the title fix: Update cronjobs to forbid concurrency fix: Pruning cron jobs should forbid concurrency Dec 10, 2024
@Sovietaced Sovietaced marked this pull request as ready for review December 10, 2024 07:22
@dejanzele dejanzele merged commit 5504878 into armadaproject:main Dec 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants