Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Actually reconcile service accounts #324

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Sovietaced
Copy link
Contributor

@Sovietaced Sovietaced commented Aug 23, 2024

c# Pull Request Template

Description

This is a follow up to #316

Even after those changes we found the armada operator controller wasn't syncing image pull secrets to service accounts that it created. After looking further I noticed that the reconciliation code does nothing with service accounts.

Fixes # (issue)

Type of change

Please select the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code Style Update (formatting, renaming)
  • Refactor (code changes that do not fix a bug or add a feature)
  • Documentation Update
  • Other (please describe):

How Has This Been Tested?

Unit test added and tested on k8s 1.29

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@dejanzele dejanzele merged commit e3bcf44 into armadaproject:main Sep 3, 2024
16 checks passed
@Sovietaced Sovietaced deleted the service-account branch September 3, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants