Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ToConstraintFieldGadget for Vec<UInt8> #36

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Implement ToConstraintFieldGadget for Vec<UInt8> #36

merged 3 commits into from
Jan 12, 2021

Conversation

Will-Lin4
Copy link
Contributor

No description provided.

@Pratyush Pratyush self-requested a review January 12, 2021 01:11
@Will-Lin4 Will-Lin4 changed the title Implement ToConstraintGadget for Vec<UInt8> Implement ToConstraintFieldGadget for Vec<UInt8> Jan 12, 2021
Pratyush
Pratyush reviewed Jan 12, 2021
View reviewed changes
src/bits/uint8.rs Outdated Show resolved Hide resolved
weikengchen
weikengchen approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@weikengchen weikengchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@Will-Lin4 Will-Lin4 requested a review from Pratyush January 12, 2021 04:19
ValarDragon
ValarDragon reviewed Jan 12, 2021
View reviewed changes
src/bits/uint8.rs Outdated Show resolved Hide resolved
ValarDragon
ValarDragon approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, beyond my last request for a comment

@Pratyush Pratyush merged commit 2432ff4 into arkworks-rs:master Jan 12, 2021
Pratyush pushed a commit that referenced this pull request Aug 8, 2021
@Will-Lin4
Implement ToConstraintFieldGadget for Vec<UInt8> (#36)
6989c26 
* Implement ToConstraintFieldGadget for Vec<UInt8>

* Add documentation and implementation for slice

* Update documentation
Pratyush pushed a commit that referenced this pull request Aug 8, 2021
@weikengchen
Fix mul_without_reduce when self is a constant (#36)
dbe5657 
* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weikengchen weikengchen weikengchen approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

@Pratyush Pratyush Awaiting requested review from Pratyush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Will-Lin4 @Pratyush @ValarDragon @weikengchen