Add UInt128 for u128 #21
Conversation
|
On the way of fixing multiple errors. May take a longer time. It seems that A separate implementation would be needed for |
|
Maybe you can use BigInteger256? |
|
Passing. But a code review is needed. This implementation uses |
|
I would merge this for now. But we likely need a revisit later (I will create an issue), very likely to replace with |
| let b = AllocatedBit::new_witness(cs.clone(), || { | ||
| result_value.map(|v| (v >> i) & 1 == 1).get() | ||
| })?; | ||
| let b = AllocatedBit::new_witness(cs.clone(), || result_value.clone().map(|v| (v >> i) & BigUint::one() == BigUint::one()).get())?; |
There was a problem hiding this comment.
I think we can rewrite this more simply as
let b = AllocatedBit::new_witness(cs.clone(), || result_value.as_ref().map(|v| (v >> i) == BigUint::one()).get())?;
| @@ -246,7 +251,12 @@ macro_rules! make_uint { | |||
| } | |||
|
|
|||
| // The value of the actual result is modulo 2^$size | |||
| let modular_value = result_value.map(|v| v as $native); | |||
| let modular_value = result_value.clone().map(|v| | |||
There was a problem hiding this comment.
We can avoid the clone here by doing as_ref() instead
| let modular_value = result_value.map(|v| v as $native); | ||
| let modular_value = result_value.clone().map(|v| | ||
| { | ||
| let modulus = BigUint::from(1u64) << ($size as u32); |
There was a problem hiding this comment.
BigUint::from(1u64) -> BigUint::one().
|
Sorry this review is kinda late lol |
No description provided.