This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
Fixed support for symbols ID which are not numbers #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent from crashing in the case we specified a wrong fragment for a symbol name. For instance an svg has a symbol abcd, if I specified `someUrl/my.svg#defg` it will fail using the onSVGFail error emitter.
|
I assume the PR title is actually negated, but thanks for the PR! |
|
@arkon you are right, I started forking the repository and changed the few lines in the code directly on master. Good practice would have been to download on my computer, create 2 separate branches and make a separate pull request for each of them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the solution on: https://stackoverflow.com/a/20306218/532695