Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Feature request: No baseURL option. #115

Closed
mikesimmonds opened this issue Aug 12, 2019 · 4 comments
Closed

Feature request: No baseURL option. #115

mikesimmonds opened this issue Aug 12, 2019 · 4 comments

Comments

@mikesimmonds
Copy link

In our project we are setting the base url in an interceptor and therefore I do not want to prepend the url with anything at all.

The feature request: To add a way of not prepending the svg url with anything at all.

I have already implemented this locally be setting .forRoot({baseUrl: null}) and then checking this in the inline-svg>getAbsoluteUrl() method and simply returning the original url.

I'm happy to submit a PR if you think this functionality would be valuable to others.

@arkon
Copy link
Owner

arkon commented Aug 12, 2019

Yeah, feel free to submit a PR! Make sure to update the documentation too.

@mikesimmonds
Copy link
Author

mikesimmonds commented Aug 12, 2019 via email

@arkon arkon closed this as completed in f169b54 Oct 7, 2019
@emzet
Copy link

emzet commented Oct 15, 2019

@arkon

Hi there, I do not think it is good approach, because with new release v9.1.0, our app does not work now. We set fake baseUrl option in InlineSVGModule and then in HttpInterceptor replace it with real one (which fetches ngx-config), but now svg requests never reach interceptor...

@arkon
Copy link
Owner

arkon commented May 30, 2020

@emzet For future reference, leaving comments on unrelated/closed issues isn't a good way to bring up issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants