This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 91
Feature request: No baseURL option. #115
Comments
Yeah, feel free to submit a PR! Make sure to update the documentation too. |
Great, I'll take a look over the next few days.
…On Mon, 12 Aug 2019, 18:26 Eugene, ***@***.***> wrote:
Yeah, feel free to submit a PR! Make sure to update the documentation too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#115?email_source=notifications&email_token=AGEMDRLXE43GM3KFQWR3TMTQEGFKZA5CNFSM4ILB3NDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4DCI2Y#issuecomment-520496235>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGEMDRISE4K4ADCIMBYRUHDQEGFKZANCNFSM4ILB3NDA>
.
|
Hi there, I do not think it is good approach, because with new release v9.1.0, our app does not work now. We set fake baseUrl option in InlineSVGModule and then in HttpInterceptor replace it with real one (which fetches ngx-config), but now svg requests never reach interceptor... |
@emzet For future reference, leaving comments on unrelated/closed issues isn't a good way to bring up issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In our project we are setting the base url in an interceptor and therefore I do not want to prepend the url with anything at all.
The feature request: To add a way of not prepending the svg url with anything at all.
I have already implemented this locally be setting .forRoot({baseUrl: null}) and then checking this in the inline-svg>getAbsoluteUrl() method and simply returning the original url.
I'm happy to submit a PR if you think this functionality would be valuable to others.
The text was updated successfully, but these errors were encountered: