[#837] Documentation and test for setting PriorityClassName #838
Conversation
|
Looks like the tests don't currently run b/c of this issue kubernetes-sigs/controller-runtime#2720 |
There was a problem hiding this comment.
@kevinfrommelt thanks for your PR but you could already customize the priorityClassName and other podSpec fields by using a strategic merge patch, for further details see https://github.com/artemiscloud/activemq-artemis-operator/issues/837#issuecomment-2016538868
After #758 new fields to customize the resource managed by the operator are added only for use cases in which a strategic merge patch doesn't work or would be too much complex.
You could change your PR to add a doc and a test to set the priorityClassName by using a strategic merge patch if that works for your use case.
|
@brusdev Thanks for the info. I'll update the PR to just include docs and tests like you suggested. |
kevinfrommelt
force-pushed
the
priority-class-name
branch
from
c43f09d to
210788e
Compare
kevinfrommelt
force-pushed
the
priority-class-name
branch
from
210788e to
625078b
Compare
kevinfrommelt
changed the title
|
@brusdev This is ready for review |
|
@kevinfrommelt thanks for your contribution and for investigating the CI error, I fixed it in #839 |
^