Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reader split #46

Merged
merged 2 commits into from
Oct 26, 2021
Merged

feat: reader split #46

merged 2 commits into from
Oct 26, 2021

Conversation

arjenzhou
Copy link
Owner

@arjenzhou arjenzhou commented Oct 26, 2021

What is the purpose of the change

#1

Brief changelog

support reader split

Verifying this change

Checklist

  • Make sure there is a ISSUE field for the change (usually
    before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should
    address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample in project.
  • Add some description to documents if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #46 (e57c3da) into master (503864d) will increase coverage by 2.00%.
The diff coverage is 66.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
+ Coverage     49.71%   51.72%   +2.00%     
- Complexity      163      173      +10     
============================================
  Files            46       46              
  Lines          1058     1131      +73     
  Branches         65       71       +6     
============================================
+ Hits            526      585      +59     
- Misses          492      503      +11     
- Partials         40       43       +3     
Impacted Files Coverage Δ
.../xab/porter/api/dataconnection/SinkConnection.java 84.84% <ø> (-1.64%) ⬇️
...b/porter/common/util/PorterNetworkInterceptor.java 0.00% <0.00%> (ø)
...e/xab/porter/transfer/http/writer/DorisWriter.java 0.00% <0.00%> (ø)
...e/xab/porter/transfer/jdbc/writer/DorisWriter.java 0.00% <ø> (ø)
.../porter/transfer/jdbc/writer/PostgreSQLWriter.java 0.00% <0.00%> (ø)
.../de/xab/porter/transfer/writer/AbstractWriter.java 65.51% <ø> (+4.22%) ⬆️
...de/xab/porter/transfer/jdbc/writer/JDBCWriter.java 50.00% <42.85%> (-1.71%) ⬇️
core/src/main/java/de/xab/porter/core/Task.java 76.62% <65.95%> (-10.88%) ⬇️
...de/xab/porter/transfer/jdbc/reader/JDBCReader.java 66.66% <73.07%> (+2.73%) ⬆️
...orter/transfer/jdbc/connector/HikariConnector.java 72.72% <75.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503864d...e57c3da. Read the comment docs.

@arjenzhou arjenzhou merged commit c2fae8e into master Oct 26, 2021
@arjenzhou arjenzhou deleted the feat-split branch October 26, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant